Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [joist-cvs] CVS update: joist/conf Makefile

Project highlights: Architectural Overview

joist
Discussion topic

Back to topic list

Re: [joist-cvs] CVS update: joist/conf Makefile

Author edk
Full name Ed Korthof
Date 2001-03-28 11:50:02 PST
Message On Wed, Mar 28, 2001 at 11:26:41AM -0800, Daniel Rall wrote:
> edk at collab dot net writes:
>
> > On Wed, Mar 28, 2001 at 09:59:21AM -0800, Daniel Rall wrote:
> > > I don't understand this commit at all. The enclosing "" around the
> > > shell variables should make the foreach thingger treat "$(VAR)" as a
> > > single element, rather than a list of elements...
> >
> > Well, without the quotes, solaris sh chokes on it cause it evaluates it
> > to:
> >
> > for f in ;
> >
> > and it sas the semicolon is unexpected. Even the if block alone isn't
> > sufficient to protect things -- sh tries to parse the stuff inside the
> > if block and chokes there.
>
> bash has no problem with this, ugh...Solaris sh is totally broken. A
> semi-colon is a statement terminator.
>
> dlr@despot:News$ for v in ; do echo 'hi'; done; unset v
> dlr@despot:News$

You'll get no argument from me ... I want to switch /bin/sh to be
/bin/bash, but the ops person we've got working with Solaris (Robert) is
concerned about breaking upgrades. If we could get 'make' to exec the
blocks of commands w/ /bin/bash instead of /bin/sh, that'd work -- but I
don't see a way to do this in the man page.

> > I'd prefer to do away with the section entirely -- there are no httpd
> > conf files, I get really sick of dealing with solaris sh stupidity like
> > this, and I don't see *any* value that the section in question brings.
> > Certainly it has brought me lots of headaches.
>
> I agree that the section should be done away with. As it currently
> stands, it's broken under bash if there is more than one element in
> the list.

In fact there are no elements, so it's not broken yet -- it's just
misleading and likely to break in the future. I'll remove it unless
someone complains loudly, 'cause that means one fewer headache (until I
get to the next Makefile which is happy w/ bash and uncooperative w/ sh).

cheers --

Ed

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: [joist-cvs] CVS update: joist/conf Makefile edk Ed Korthof 2001-03-28 11:50:02 PST
Messages per page: