Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: CVS update: MODIFIED: security ...

Project highlights: Architectural Overview

joist
Discussion topic

Back to topic list

Re: CVS update: MODIFIED: security ...

Author stack
Full name Michael Stack
Date 2001-05-04 17:42:17 PDT
Message Michael Salmon wrote:

> On Fri, May 04, 2001 at 02:40:56PM -0700, Michael St.Ack wrote:
>
>> The indentation in the src file is different from what shows below. I
>> think it correct there.
>>
>> Is there a convention that a single-line following a conditional test be
>> wrapped in braces?
>
>
> I dont like in java to have single line blocks with no braces. Simply
> because people tend to use it inconsistently in their code. Either we
> use a languag that has a model of no braces and just indenting (python)
> or I recommend we just use braces where they are useful.
>
Could you give some examples of said inconsistencies and could you
tighten up what you mean when you say 'recommend we just use braces
where they are useful'.

Sun coding conventions recomment wrapping single line blocks after ifs:
http://java.sun.com/​docs/codeconv/html/C​odeConventions.doc6.​html#449

I think its OTT but I do not have strong feelings on the matter.

St.Ack


>
>
>> I appreciate the review.
>>
>> St.Ack
>>
>>
>> Daniel Rall wrote:
>>
>>
>>> Enclosing braces? Indentation?
>>>
>>> stack at tigris dot org writes:
>>>
>>>
>>>
>>>> @@ -274,6 +281,7 @@
>>>> }
>>>>
>>>> // Process the template.
>>>> + if( templateName != null )
>>>> TurbineWebMacro.hand​leRequest(context, templateName,
>>>> res.getOutputStream());
>>>> //, res.getCharacterEncoding());
>>>
>>>
>>> --------------------​--------------------​--------------------​---------
>>> To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
>>> For additional commands, e-mail: dev-help at joist dot tigris dot org
>>
>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
>> For additional commands, e-mail: dev-help at joist dot tigris dot org
>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
> For additional commands, e-mail: dev-help at joist dot tigris dot org



--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
For additional commands, e-mail: dev-help at joist dot tigris dot org

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: CVS update: MODIFIED: security ... stack Michael Stack 2001-05-04 17:42:17 PDT
Messages per page: