Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Project highlights: Architectural Overview

joist
Discussion topic

Back to topic list

Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Author brian
Full name Brian Behlendorf
Date 2000-04-21 13:20:00 PDT
Message Sorry for the nitpicky comments, just want to get this right.

On 21 Apr 2000 commitlogger at hocus dot collab dot net wrote:
> * Copyright (c) 1999 dataweb systems, inc.
> - * Copyright (c) 1999, 2000 Collab.Net, Inc.

All code on tigris.org should be copyright Collab.Net until we set up a
non-profit org for Tigris.org development. We should make sure a copy of
the Tigris license is in each CVS module.

> */
>
> public class Emailer extends Object
> {
> static private Log log = new Log("emailer", "Emailer");
> static private boolean debug = true;
> + static private String sender = "notifier at sourcexchange dot com";

Double-Erm... this should be abstracted out to a properties file, in fact
all mentioned of sourcexchange in joist should be abstracted out.

Also, this module seems to duplicate a lot of the functionality from the
JavaMail API.... or am I wrong?

> + StringBuffer listName = new StringBuffer("project");
> + String mailHost = System.getProperty("​org.sourcexchange.ma​ilhost");

More abstraction.

> + recipients.addElemen​t(getProjectList(pro​jectID));

This seems pretty sXc-dependent...

    Brian

--
-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=
collab.net | open source | do what's right | now hiring smart people

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java brian Brian Behlendorf 2000-04-21 13:20:00 PDT
     Re: [joist-dev] Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java David Pellegrini <davidp at xsitedesign dot com> David Pellegrini <davidp at xsitedesign dot com> 2000-04-21 14:40:00 PDT
         Re: [joist-dev] Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java brian Brian Behlendorf 2000-04-21 15:03:57 PDT
Messages per page: