Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: CVS update: MODIFIED: security ...

Project highlights: Architectural Overview

joist
Discussion topic

Hide all messages in topic

All messages in topic

Re: CVS update: MODIFIED: security ...

Author dlr
Full name Daniel Rall
Date 2001-05-05 10:58:40 PDT
Message "Michael St.Ack" <stack at collab dot net> writes:

> Nope. There are no tabs in the src.

I removed all the tabs from UnsecureServlet last month. Die tabs, die.

--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
For additional commands, e-mail: dev-help at joist dot tigris dot org

Re: CVS update: MODIFIED: security ...

Author stack
Full name Michael Stack
Date 2001-05-05 09:19:57 PDT
Message Nope. There are no tabs in the src.
St.Ack


Jon Stevens wrote:

> on 5/4/01 4:57 PM, "Daniel Rall" <dlr at finemaltcoding dot com> wrote:
>
>
>> "Michael St.Ack" <stack at collab dot net> writes:
>>
>>
>>> The indentation in the src file is different from what shows below. I
>>> think it correct there.
>>
>> Yes, oddly it was.
>
>
> Not oddly, I bet it was a tab that caused the problem.
>
> [space][tab to indent]
>
> Tabs in the files is bad as well.
>
> -jon
>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
> For additional commands, e-mail: dev-help at joist dot tigris dot org



--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
For additional commands, e-mail: dev-help at joist dot tigris dot org

Re: CVS update: MODIFIED: security ...

Author Jon Stevens <jon at latchkey dot com>
Full name Jon Stevens <jon at latchkey dot com>
Date 2001-05-04 17:57:17 PDT
Message on 5/4/01 4:57 PM, "Daniel Rall" <dlr at finemaltcoding dot com> wrote:

> "Michael St.Ack" <stack at collab dot net> writes:
>
>> The indentation in the src file is different from what shows below. I
>> think it correct there.
>
> Yes, oddly it was.

Not oddly, I bet it was a tab that caused the problem.

[space][tab to indent]

Tabs in the files is bad as well.

-jon


--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
For additional commands, e-mail: dev-help at joist dot tigris dot org

Re: CVS update: MODIFIED: security ...

Author dlr
Full name Daniel Rall
Date 2001-05-04 16:57:40 PDT
Message "Michael St.Ack" <stack at collab dot net> writes:

> The indentation in the src file is different from what shows below. I
> think it correct there.

Yes, oddly it was.

> Is there a convention that a single-line following a conditional test
> be wrapped in braces?

I was objecting more to the fact that there appeared to be neither
braces nor indention (which turned out to not be the case). I usually
wrap single line blocks in comments, but don't feel strongly about
it. Michael Salmon does make a good point about consistancy. Perhaps
someone is interested in proposing a patch to the coding standards?

> I appreciate the review.

No prob.

Dan

--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@jois​t.tigris.org
For additional commands, e-mail: dev-help at joist dot tigris dot org
Messages per page: