Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Project highlights: Architectural Overview

joist
Discussion topic

Hide all messages in topic

All messages in topic

Re: [joist-dev] Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Author brian
Full name Brian Behlendorf
Date 2000-04-21 15:03:57 PDT
Message On Fri, 21 Apr 2000, David Pellegrini wrote:
> Yup. These abstraction fouls crept in late in the game with Carl's recent
> email notification work. I'm bringing sXc mods over and integrating them in
> as I go, but I'm not spending a whole lot of time on complete abstraction.
> Right now, I'm just trying to get sXc to compile cleanly on joist. I'll deal
> with this afterward. It's on the todo list :^)

No sweat, just making sure. =)

    Brian

--
-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=
collab.net | open source | do what's right | now hiring smart people

Re: [joist-dev] Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Author David Pellegrini <davidp at xsitedesign dot com>
Full name David Pellegrini <davidp at xsitedesign dot com>
Date 2000-04-21 14:40:00 PDT
Message Hi Brian!

Brian Behlendorf wrote:
>
> Sorry for the nitpicky comments, just want to get this right.
>
> On 21 Apr 2000 commitlogger at hocus dot collab dot net wrote:
> > * Copyright (c) 1999 dataweb systems, inc.
> > - * Copyright (c) 1999, 2000 Collab.Net, Inc.

Cut 'n paste error. Fixed.

>
> All code on tigris.org should be copyright Collab.Net until we set up a
> non-profit org for Tigris.org development. We should make sure a copy of
> the Tigris license is in each CVS module.
>
> > */
> >
> > public class Emailer extends Object
> > {
> > static private Log log = new Log("emailer", "Emailer");
> > static private boolean debug = true;
> > + static private String sender = "notifier at sourcexchange dot com";
>
> Double-Erm... this should be abstracted out to a properties file, in fact
> all mentioned of sourcexchange in joist should be abstracted out.
>
> Also, this module seems to duplicate a lot of the functionality from the
> JavaMail API.... or am I wrong?

Email.java is a wrapper around JavaMail

>
> > + StringBuffer listName = new StringBuffer("project");
> > + String mailHost = System.getProperty("​org.sourcexchange.ma​ilhost");
>
> More abstraction.
>
> > + recipients.addElemen​t(getProjectList(pro​jectID));
>
> This seems pretty sXc-dependent...
>
> Brian

Yup. These abstraction fouls crept in late in the game with Carl's recent
email notification work. I'm bringing sXc mods over and integrating them in
as I go, but I'm not spending a whole lot of time on complete abstraction.
Right now, I'm just trying to get sXc to compile cleanly on joist. I'll deal
with this afterward. It's on the todo list :^)

-davidp

Re: [joist-cvs] CVS update: joist/java/org/joist/mail Emailer.java

Author brian
Full name Brian Behlendorf
Date 2000-04-21 13:20:00 PDT
Message Sorry for the nitpicky comments, just want to get this right.

On 21 Apr 2000 commitlogger at hocus dot collab dot net wrote:
> * Copyright (c) 1999 dataweb systems, inc.
> - * Copyright (c) 1999, 2000 Collab.Net, Inc.

All code on tigris.org should be copyright Collab.Net until we set up a
non-profit org for Tigris.org development. We should make sure a copy of
the Tigris license is in each CVS module.

> */
>
> public class Emailer extends Object
> {
> static private Log log = new Log("emailer", "Emailer");
> static private boolean debug = true;
> + static private String sender = "notifier at sourcexchange dot com";

Double-Erm... this should be abstracted out to a properties file, in fact
all mentioned of sourcexchange in joist should be abstracted out.

Also, this module seems to duplicate a lot of the functionality from the
JavaMail API.... or am I wrong?

> + StringBuffer listName = new StringBuffer("project");
> + String mailHost = System.getProperty("​org.sourcexchange.ma​ilhost");

More abstraction.

> + recipients.addElemen​t(getProjectList(pro​jectID));

This seems pretty sXc-dependent...

    Brian

--
-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=-=-=-=​-=-=-=-=-=-=-=
collab.net | open source | do what's right | now hiring smart people
Messages per page: