Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [joist-dev] make/sh ugliness

Project highlights: Architectural Overview

joist
Discussion topic

Back to topic list

Re: [joist-dev] make/sh ugliness

Author Jon Stevens <jon at latchkey dot com>
Full name Jon Stevens <jon at latchkey dot com>
Date 2000-12-18 17:09:03 PST
Message on 12/18/2000 4:52 PM, "Ed Korthof" <edk at collab dot net> wrote:

> for f in $(HTTPD_CONF_FILES); do \
> echo " $${f}"; \
> if [ -f $(HTTPD_CONF_DIR)/$${f} ]; then \
> mv $(HTTPD_CONF_DIR)/$${f} $(HTTPD_CONF_DIR)/$${f}.orig; \
> fi; \
> cp -f $${f}* $(HTTPD_CONF_DIR); \
> done; \
> dies unpleasantly if $(HTTPD_CONF_FILES) is empty, as it is in
> joist/conf/Makefile (HTTPD_CONF_FILES is empty in the corresponding
> Makefile.config).

Ok, so then why not:

if [ ! -z "$(HTTPD_CONF_FILES)" ] ; then
        for f in $(HTTPD_CONF_FILES); do \
          echo " $${f}"; \
          if [ -f $(HTTPD_CONF_DIR)/$${f} ]; then \
            mv $(HTTPD_CONF_DIR)/$${f} $(HTTPD_CONF_DIR)/$${f}.orig; \
          fi; \
          cp -f $${f}* $(HTTPD_CONF_DIR); \
        done; \
fi

??. Or am I missing the point.

-jon

--
Honk if you love peace and quiet.

« Previous message in topic | 2 of 5 | Next message in topic »

Messages

Show all messages in topic

make/sh ugliness edk Ed Korthof 2000-12-18 16:52:30 PST
     Re: [joist-dev] make/sh ugliness Jon Stevens <jon at latchkey dot com> Jon Stevens <jon at latchkey dot com> 2000-12-18 17:09:03 PST
         Re: [joist-dev] make/sh ugliness edk Ed Korthof 2000-12-18 17:28:27 PST
             Re: [joist-dev] make/sh ugliness Jon Stevens <jon at latchkey dot com> Jon Stevens <jon at latchkey dot com> 2000-12-18 17:35:51 PST
                 Re: [joist-dev] make/sh ugliness edk Ed Korthof 2000-12-18 17:46:30 PST
Messages per page: