Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [joist-cvs] CVS update: joist/java/org/joist/util FormCache.java

Project highlights: Architectural Overview

joist
Discussion topic

Back to topic list

Re: [joist-cvs] CVS update: joist/java/org/joist/util FormCache.java

Author David Pellegrini <davidp at xsitedesign dot com>
Full name David Pellegrini <davidp at xsitedesign dot com>
Date 2000-11-04 02:28:33 PST
Message Hi Ed!

This looks good. :^)

One reservation, though, about FormCache.override. It simply replaces the current request's form data with the saved request's form data. I'm wondering if there might not be something of value in the current request's form data that we want to retain. If yes, then we need to augment the current request's form data with form data from the saved context (or vice-versa).

-davidp

edk at tigris dot org wrote:
>
> User: edk
> Date: 00/11/03 20:16:42
>
> Modified: java/org/joist/security UnsecureServlet.java
> java/org/joist/session SessionManager.java
> java/org/joist/util FormCache.java
> Log:
> Changes designed to support redirects better. While the new WebMacro
> doesn't provide a means to update the context, we have control over
> and access to the object used to store form data -- FormCache -- so we
> can override the underlying object which it contains. FormCache has
> been updated for that and reformated slightly.
>
> UnsecureServlet and SessionManager now use that interface to override
> the form parameters after a redirect back. In addition, they store
> the old context (so that servlets which have saved data in it can get
> access to it) in the current context, keyed as
> UnsecureServlet.SAVE​D_CONTEXT_KEY.
>
> A debugging breadcrumb which crept in has been excised.
>

[snip]

> Index: FormCache.java

> + final public void override(FormCache other) {
> + this.pp = other.pp;
> + }

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: [joist-cvs] CVS update: joist/java/org/joist/util FormCache.java David Pellegrini <davidp at xsitedesign dot com> David Pellegrini <davidp at xsitedesign dot com> 2000-11-04 02:28:33 PST
Messages per page: